kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1622159510
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
isCancelled(), isLeader());
return;
}
+
+ copyQuotaManagerLock.lock();
+ try {
+ while (rlmCopyQuotaManager.isQuotaExceeded()) {
+ logger.debug("Quota exceeded for copying
log segments, waiting for the quota to be available.");
+ try {
+
copyQuotaManagerLockCondition.await(quotaTimeout().toMillis(),
TimeUnit.MILLISECONDS);
+ } catch (InterruptedException e) {
Review Comment:
We are catching the InterruptedException:
1. does it delays the shutdown? If yes, do we have to add a check whether
the task is cancelled before copying the log segment?
2. Why the logger level is set to WARN? can it be reduced to INFO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
