dajac commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1621843638
##########
core/src/test/java/kafka/test/ClusterInstance.java:
##########
@@ -159,9 +158,7 @@ default Set<GroupProtocol> supportedGroupProtocols() {
Set<GroupProtocol> supportedGroupProtocols = new HashSet<>();
supportedGroupProtocols.add(CLASSIC);
- // KafkaConfig#isNewGroupCoordinatorEnabled check both
NEW_GROUP_COORDINATOR_ENABLE_CONFIG and
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG
- if (serverProperties.getOrDefault(NEW_GROUP_COORDINATOR_ENABLE_CONFIG,
"").equals("true") ||
Review Comment:
We will eventually remove it for sure. This (private) config is still the
one use to determine whether the new group coordinator should be enabled or
not. The trick to know is that it is automatically set to true when `consumer`
is specified as a protocol. We made this to simplify the early access and the
preview.
The handling was a bit messy before this patch as the new protocol was
enabled whenever the new coordinator ran. It is better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
