gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1621586240
##########
checkstyle/suppressions.xml:
##########
@@ -361,4 +361,7 @@
<suppress checks="(ClassDataAbstractionCoupling|ClassFanOutComplexity)"
files="(ReplicaFetcherThreadBenchmark).java"/>
+ <!--import order -->
+ <suppress checks="ImportOrder" files="^*$"/>
Review Comment:
I think checkstyle should consistent with auto format . If you open the A
module auto format, we should open the module check rule.
`ImportOrder` rule can't custom in each module(It's going to take a lot of
changes,maybe should add build.gradle every module).
So i add this line in order that open rule some module in future,This is
what I think is a more convenient way to modify by module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
