cmccabe commented on code in PR #15986:
URL: https://github.com/apache/kafka/pull/15986#discussion_r1619507872
##########
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##########
@@ -156,22 +156,24 @@ public boolean canGrantVote(ReplicaKey candidateKey,
boolean isLogUpToDate) {
log.debug(
"Rejecting vote request from candidate ({}) since we already have
a leader {} in epoch {}",
candidateKey,
- leaderId(),
+ leader,
epoch
);
return false;
}
@Override
public String toString() {
- return "FollowerState(" +
- "fetchTimeoutMs=" + fetchTimeoutMs +
- ", epoch=" + epoch +
- ", leaderId=" + leaderId +
- ", voters=" + voters +
- ", highWatermark=" + highWatermark +
- ", fetchingSnapshot=" + fetchingSnapshot +
- ')';
+ return String.format(
Review Comment:
I'm not sure I see a lot of benefit to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
