C0urante opened a new pull request, #16122:
URL: https://github.com/apache/kafka/pull/16122

   Jira tickets: 
[KAFKA-16837](https://issues.apache.org/jira/browse/KAFKA-16837), 
[KAFKA-16838](https://issues.apache.org/jira/browse/KAFKA-16838)
   
   This PR contains two small functional changes:
   
   1. For KAFKA-16837, the logic for comparing existing and new task configs is 
altered to skip config provider transformation. This should have no impact on 
behavior (besides fixing the bug described in the Jira ticket), since the 
current logic performs transformation on both sets of task configs at the same 
time, making it impossible to detect changes in the transformed values anyways. 
See [KAFKA-9228](https://issues.apache.org/jira/browse/KAFKA-9228) and a couple 
of in-progress PRs (https://github.com/apache/kafka/pull/16001, 
https://github.com/apache/kafka/pull/16053) for possible solutions to the 
problem of detecting changes in config provider values.
   2. For KAFKA-16838, the logic for materializing a view of the config topic 
is altered to ignore task configs when there is no configuration for that 
connector present earlier in the config topic. This handles the case where a 
connector has been deleted, then compaction has taken place, removing both the 
connector config and the subsequent tombstone message for it from the config 
topic.
   
   Unit testing coverage is added for both changes.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to