appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1618318070
##########
clients/src/main/java/org/apache/kafka/clients/ClientUtils.java:
##########
@@ -172,7 +173,37 @@ public static NetworkClient
createNetworkClient(AbstractConfig config,
null,
new DefaultHostResolver(),
throttleTimeSensor,
- clientTelemetrySender);
+ clientTelemetrySender,
+ Function.identity());
Review Comment:
Are you suggesting creating a RequestManager for Metadata Errors?
In my understanding, the role of a RequestManager is to manage outgoing
requests.
However, looking at the MembershipManagerImpl, It doesn't seem like its role
is necessarily limited to requests.
By adopting this approach, we could propagate Metadata Error while
maintaining the structure of the new Consumer.
So I think it's good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
