dajac commented on PR #16088: URL: https://github.com/apache/kafka/pull/16088#issuecomment-2136604335
@jeffkbkim Your understanding is correct. The biggest gain comes from the rewrite of the "assign sticky partitions" methods. I did two things there: a) avoid the intermediate data structure (the topicpartition list); and b) avoid copying unchanged assignments. Regarding your point 3), the sorting does not have a real impact on the incremental case but it does have in the full assignment case. As you saw, we don't need it. Note that we don't use a Set anymore for the unassigned partitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
