chia7712 commented on code in PR #16017:
URL: https://github.com/apache/kafka/pull/16017#discussion_r1618190171
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -880,4 +880,25 @@ private HeartbeatRequestManager
createHeartbeatRequestManager(
backgroundEventHandler,
metrics);
}
+
+
+ @Test
+ public void reproduceHeartbeatFail() throws InterruptedException {
+ mockStableMember();
+ time.sleep(DEFAULT_HEARTBEAT_INTERVAL_MS);
+ NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(1, result.unsentRequests.size());
+
+ result = heartbeatRequestManager.poll(time.milliseconds());
+ assertEquals(0, result.unsentRequests.size(), "No heartbeat should be
sent while a previous one is in-flight");
+
+ membershipManager.transitionToSendingLeaveGroup(true);
Review Comment:
+1 to `membershipManager.leaveGroup()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
