showuon commented on code in PR #15860:
URL: https://github.com/apache/kafka/pull/15860#discussion_r1616820915
##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -58,13 +58,17 @@ public class SocketServerConfigs {
public static final String ADVERTISED_LISTENERS_CONFIG =
"advertised.listeners";
public static final String ADVERTISED_LISTENERS_DOC = String.format(
- "Listeners to publish to ZooKeeper for clients to use, if
different than the <code>%s</code> config property." +
- " In IaaS environments, this may need to be different from
the interface to which the broker binds." +
- " If this is not set, the value for <code>%1$1s</code>
will be used." +
- " Unlike <code>%1$1s</code>, it is not valid to advertise
the 0.0.0.0 meta-address.%n" +
- " Also unlike <code>%1$1s</code>, there can be duplicated
ports in this property," +
- " so that one listener can be configured to advertise
another listener's address." +
- " This can be useful in some cases where external load
balancers are used.", LISTENERS_CONFIG);
+ "Specifies the listener addresses that the Kafka brokers will
advertise to clients and other brokers." +
+ " The config is useful where the actual listener configuration
<code>%s</code> does not represent the addresses that clients should" +
+ " use to connect, such as in cloud environments. In environments
using ZooKeeper, these addresses are published to ZooKeeper." +
+ " In KRaft mode, these addresses are managed internally by the
Kafka brokers themselves. Regardless of the operating mode, this config" +
Review Comment:
> In KRaft mode, these addresses are managed internally by the Kafka brokers
themselves.
Is this correct? I mean, yes, they have metadataCache, like in ZK, the
broker also has metadataCache. But in ZK, we'll publish to ZK, so in KRaft,
where will we publish the advertised listener to?
##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -58,13 +58,17 @@ public class SocketServerConfigs {
public static final String ADVERTISED_LISTENERS_CONFIG =
"advertised.listeners";
public static final String ADVERTISED_LISTENERS_DOC = String.format(
- "Listeners to publish to ZooKeeper for clients to use, if
different than the <code>%s</code> config property." +
- " In IaaS environments, this may need to be different from
the interface to which the broker binds." +
- " If this is not set, the value for <code>%1$1s</code>
will be used." +
- " Unlike <code>%1$1s</code>, it is not valid to advertise
the 0.0.0.0 meta-address.%n" +
- " Also unlike <code>%1$1s</code>, there can be duplicated
ports in this property," +
- " so that one listener can be configured to advertise
another listener's address." +
- " This can be useful in some cases where external load
balancers are used.", LISTENERS_CONFIG);
+ "Specifies the listener addresses that the Kafka brokers will
advertise to clients and other brokers." +
+ " The config is useful where the actual listener configuration
<code>%s</code> does not represent the addresses that clients should" +
Review Comment:
Should we use `<code>%1$1s</code>` as below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
