agavra commented on code in PR #16074:
URL: https://github.com/apache/kafka/pull/16074#discussion_r1613946161
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -820,6 +820,9 @@ public class StreamsConfig extends AbstractConfig {
+ "optimization algorithm favors minimizing cross rack traffic or
minimize the movement of tasks in existing assignment. If set a larger value
<code>" + RackAwareTaskAssignor.class.getName() + "</code> will "
+ "optimize to maintain the existing assignment. The default value is
null which means it will use default non_overlap cost values in different
assignors.";
+ @SuppressWarnings("WeakerAccess")
+ public static final String TASK_ASSIGNOR_CLASS_CONFIG =
"task.assignor.class";
+ private static final String TASK_ASSIGNOR_CLASS_DOC = "A task assignor
class or class name implementing the <@link TaskAssignor> interface. Defaults
to the <@link HighAvailabilityTaskAssignor> class.";
Review Comment:
If I'm reading the code correctly, the javadocs are not correct. If you
specify `HighAvailabilityTaskAssignor.class` it will use the new code path vs.
if you use null it'll use the old code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
