chia7712 commented on code in PR #16044:
URL: https://github.com/apache/kafka/pull/16044#discussion_r1611740614
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java:
##########
@@ -139,7 +139,7 @@ public boolean populateTopicsToDescribe(final Set<String>
topicsToDescribe,
return populateTopicsToDescribe(fullMetadata,
changelogPartitionsForTask, partitionsForTask, changelog, topicsToDescribe,
racksForPartition);
}
- public static boolean populateTopicsToDescribe(final Cluster fullMetadata,
Review Comment:
ditto.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java:
##########
@@ -188,7 +188,7 @@ private boolean validateTopicPartitionRack(final boolean
changelogTopics) {
*
* @return whether the operation successfully completed and the rack
information is valid.
*/
- public static boolean validateTopicPartitionRack(final Cluster
fullMetadata,
+ public boolean validateTopicPartitionRack(final Cluster fullMetadata,
Review Comment:
If this method is not static method, we don't need to keep two varieties.
Could you please merge two `validateTopicPartitionRack` into single one. Also,
the new method can be package-private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
