gharris1727 commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1610617003
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -219,6 +219,19 @@ public class CommonClientConfigs {
public static final String DEFAULT_API_TIMEOUT_MS_DOC = "Specifies the
timeout (in milliseconds) for client APIs. " +
"This configuration is used as the default timeout for all client
operations that do not specify a <code>timeout</code> parameter.";
+ public static final String METADATA_RECOVERY_STRATEGY_CONFIG =
"metadata.recovery.strategy";
+ public static final String METADATA_RECOVERY_STRATEGY_DOC = "Controls how
the client recovers when none of the brokers known to it is available. " +
+ "If set to <code>none</code>, the client fails. If set to
<code>rebootstrap</code>, " +
+ "the client repeats the bootstrap process using
<code>bootstrap.servers</code>. " +
+ "Rebootstrapping is useful when a client communicates with brokers
so infrequently " +
+ "that the set of brokers may change entirely before the client
refreshes metadata. " +
+ "Opportunities to rebootstrapping depend on connection
establishing and reconnect timeouts and the broker count. " +
+ "The timeouts may prevent identifying brokers as unavailable
simultaneously, which is necessary to trigger rebootstrapping. " +
Review Comment:
This section is very confusing for me, and I think this should be reworded.
Maybe it can flow like this: "Metadata recovery is triggered when all
last-known brokers appear unavailable simultaneously. Brokers appear
unavailable when disconnected and no current retry attempt is in-progress."
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
Review Comment:
Stuff in this package is not included in the public API:
https://kafka.apache.org/37/javadoc/index.html only the stuff in
admin/producer/consumer (and not in sub-packages) is truly public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
