pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1610368294
##########
core/src/test/scala/unit/kafka/admin/AclCommandTest.scala:
##########
@@ -122,19 +128,27 @@ class AclCommandTest extends QuorumTestHarness with
Logging {
super.tearDown()
}
+ override protected def kraftControllerConfigs(): Seq[Properties] = {
+ val controllerConfig = new Properties
+ controllerConfig.put(KafkaConfig.AuthorizerClassNameProp,
classOf[StandardAuthorizer].getName)
+ controllerConfig.put(StandardAuthorizer.SUPER_USERS_CONFIG,
"User:ANONYMOUS")
+ Seq(controllerConfig)
+ }
+
@Test
def testAclCliWithAuthorizer(): Unit = {
testAclCli(zkArgs)
}
- @Test
- def testAclCliWithAdminAPI(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk"))
Review Comment:
Some tests are failing in Kraft mode because of a race condition, which we
[discussed
above](https://github.com/apache/kafka/pull/15830#discussion_r1585713585)
Currently I'm trying to rewrite the whole test in java and migrate to new
test infrastructure. Hopefully, it will solve the race condition issue. If it
doesn't help, then probably we'll have to remove some failing checks from the
test or alternatively change the output of the AclCommand tool itself.
I've removed kraft support from those test for now, just to make a jenkins
build pass. Planning to remove this scala test complately, and replace if with
a new java test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
