dajac commented on code in PR #15970:
URL: https://github.com/apache/kafka/pull/15970#discussion_r1609560175
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -133,13 +135,13 @@ public void
testFirstAssignmentTwoMembersTwoTopicsNoMemberRacks() {
members.put(memberA, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic3Uuid),
+ mkSet(topic1Uuid, topic3Uuid),
Review Comment:
nit: Indentation is off.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -337,7 +337,7 @@ public void
testReassignmentWhenPartitionsAreAddedForTwoMembersTwoTopics() {
members.put(memberA, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -350,7 +350,7 @@ public void
testReassignmentWhenPartitionsAreAddedForTwoMembersTwoTopics() {
members.put(memberB, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -409,15 +409,15 @@ public void
testReassignmentWhenOneMemberAddedAfterInitialAssignmentWithTwoMembe
members.put(memberB, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -398,7 +398,7 @@ public void
testReassignmentWhenOneMemberAddedAfterInitialAssignmentWithTwoMembe
members.put(memberA, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -286,7 +286,7 @@ public void
testReassignmentForTwoMembersTwoTopicsGivenUnbalancedPrevAssignment(
members.put(memberB, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -409,15 +409,15 @@ public void
testReassignmentWhenOneMemberAddedAfterInitialAssignmentWithTwoMembe
members.put(memberB, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
currentAssignmentForB
));
// Add a new member to trigger a re-assignment.
members.put(memberC, new AssignmentMemberSpec(
Optional.empty(),
Optional.empty(),
- Arrays.asList(topic1Uuid, topic2Uuid),
+ mkSet(topic1Uuid, topic2Uuid),
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
