lianetm commented on code in PR #15869:
URL: https://github.com/apache/kafka/pull/15869#discussion_r1603537376
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1482,7 +1486,7 @@ private void updatePatternSubscription(Cluster cluster) {
.collect(Collectors.toSet());
if (subscriptions.subscribeFromPattern(topicsToSubscribe)) {
applicationEventHandler.add(new SubscriptionChangeEvent());
- metadata.requestUpdateForNewTopics();
+ this.metadataVersionSnapshot =
metadata.requestUpdateForNewTopics();
Review Comment:
Since we're completing the regex implementation, could you clean up the func
doc? We should remove the TODO, and I would suggest we rephrase the
description, and simply state what this evaluates the regex against the list of
topic names from metadata, and updates the subscription state with the matching
topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
