cmccabe commented on code in PR #15876:
URL: https://github.com/apache/kafka/pull/15876#discussion_r1599217166
##########
clients/src/main/java/org/apache/kafka/common/TopicPartition.java:
##########
@@ -28,12 +28,19 @@ public final class TopicPartition implements Serializable {
private int hash = 0;
private final int partition;
private final String topic;
+ private int designatedLeader = -1;
Review Comment:
I don't think this change should be in as fundamental a class as
TopicPartition. This is used all over the place in Kafka and a change here will
impact efficiency (and readability)
Instead, we should create a subclass of this, that AdminClient can use. Then
we have to test if the TopicPartition we're passed is one of those (yes, it's
messy, but it preserves compatibility).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
