jsancio commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1595780757
##########
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##########
@@ -63,7 +66,9 @@ public void tearDown() {
private QuorumState buildQuorumState(Set<Integer> voters) {
return new QuorumState(
OptionalInt.of(localId),
- voters,
+ localDirectoryId,
+ () -> VoterSetTest.voterSet(VoterSetTest.voterMap(voters, false)),
+ () -> (short) 0,
Review Comment:
I made the parameterized and configured them to run with `kraft.version` 0
and 1.
In general we didn't really need to test both cases because `kraft.version`
affects the persisted state not the in-memory state. Since those tests are not
recreating a `QuorumState` object they don't affect the directory id used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
