lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594199948
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -3232,7 +3231,7 @@ public void
testProducerBatchRetriesWhenPartitionLeaderChanges() throws Exceptio
assertTrue(client.hasInFlightRequests());
client.respond(produceResponse(tp0, -1,
Errors.NOT_LEADER_OR_FOLLOWER, 0));
sender.runOnce(); // receive produce response, batch scheduled for
retry
- assertTrue(!futureIsProduced.isDone(), "Produce request is yet not
done.");
+ assertFalse(futureIsProduced.isDone(), "Produce request is yet not
done.");
Review Comment:
Looks to me this error message is inverted too right? it's stating the
desired state, not the failure: if the assert fails, it's because the produce
request **is done** when it shouldn't (not because "is yet not done"). Maybe
just "Produce request shouldn't complete yet"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
