chia7712 commented on code in PR #15872:
URL: https://github.com/apache/kafka/pull/15872#discussion_r1593354055
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##########
@@ -57,28 +56,47 @@
import static org.junit.jupiter.api.Assertions.assertNull;
@Tag("integration")
-@ClusterTestDefaults(clusterType = Type.ALL, serverProperties = {
- @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
- @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1"),
- @ClusterConfigProperty(key = "group.coordinator.new.enable", value =
"true")
-})
@ExtendWith(ClusterTestExtensions.class)
public class DeleteOffsetsConsumerGroupCommandIntegrationTest {
public static final String TOPIC_PREFIX = "foo.";
public static final String GROUP_PREFIX = "test.group.";
private final ClusterInstance clusterInstance;
- private final Iterable<Map<String, Object>> consumerConfigs;
-
DeleteOffsetsConsumerGroupCommandIntegrationTest(ClusterInstance
clusterInstance) {
this.clusterInstance = clusterInstance;
- this.consumerConfigs = clusterInstance.isKRaftTest()
- ?
Arrays.asList(Collections.singletonMap(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
GroupProtocol.CLASSIC.name()),
- Collections.singletonMap(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
GroupProtocol.CONSUMER.name()))
- : Collections.singletonList(Collections.emptyMap());
}
- @ClusterTest
+ private static void generator(ClusterGenerator clusterGenerator) {
+ Map<String, String> serverProperties = new HashMap<>();
Review Comment:
Please use `ConsumerGroupCommandTestUtils#generator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
