yashmayya commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1590316538
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##########
@@ -141,24 +145,13 @@ private static String noClientId() {
protected KafkaBasedLog<byte[], byte[]> offsetLog;
// Visible for testing
final HashMap<ByteBuffer, ByteBuffer> data = new HashMap<>();
+ private final Map<String, Set<Map<String, Object>>> connectorPartitions =
new HashMap<>();
+ private Converter keyConverter;
private final Supplier<TopicAdmin> topicAdminSupplier;
private final Supplier<String> clientIdBase;
private SharedTopicAdmin ownTopicAdmin;
protected boolean exactlyOnce;
- /**
- * Create an {@link OffsetBackingStore} backed by a Kafka topic. This
constructor will cause the
- * store to instantiate and close its own {@link TopicAdmin} during {@link
#configure(WorkerConfig)}
- * and {@link #stop()}, respectively.
- *
- * @deprecated use {@link #KafkaOffsetBackingStore(Supplier, Supplier)}
instead
- */
- @Deprecated
- public KafkaOffsetBackingStore() {
Review Comment:
@chia7712 I've raised this PR to remove the other two deprecated
constructors - https://github.com/apache/kafka/pull/15865 (and also added some
context in the PR on why deprecation was introduced rather than removal even
though these classes are not in the public API).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
