mjsax commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1587018485
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorError.java:
##########
@@ -19,20 +19,31 @@
public enum AssignorError {
// Note: this error code should be reserved for fatal errors, as the
receiving clients are future-proofed
// to throw an exception upon an unrecognized error code.
- NONE(0),
- INCOMPLETE_SOURCE_TOPIC_METADATA(1),
- VERSION_PROBING(2), // not actually used anymore, but we may hit it during
a rolling upgrade from earlier versions
- ASSIGNMENT_ERROR(3),
- SHUTDOWN_REQUESTED(4);
+ NONE(0, "NONE", "NONE"),
+ INCOMPLETE_SOURCE_TOPIC_METADATA(1,
"INCOMPLETE_SOURCE_TOPIC_METADATA","Missing source topics are existed. To check
which topics are missing, please look into the logs of the consumer group
leader. Only the leaders knows and logs the name of the missing topics."),
+ VERSION_PROBING(2, "VERSION_PROBING", "VERSION_PROBING"), // not actually
used anymore, but we may hit it during a rolling upgrade from earlier versions
+ ASSIGNMENT_ERROR(3, "ASSIGNMENT_ERROR", "Hit an unexpected exception
during task assignment phase of rebalance."),
+ SHUTDOWN_REQUESTED(4, "SHUTDOWN_REQUESTED","Encountered fatal error, and
should send shutdown request for the entire application.");
Review Comment:
```suggestion
SHUTDOWN_REQUESTED(4, "SHUTDOWN_REQUESTED", "A KafkaStreams instance
encountered a fatal error and requested a shutdown for the entire
application.");
```
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorError.java:
##########
@@ -19,20 +19,31 @@
public enum AssignorError {
// Note: this error code should be reserved for fatal errors, as the
receiving clients are future-proofed
// to throw an exception upon an unrecognized error code.
- NONE(0),
- INCOMPLETE_SOURCE_TOPIC_METADATA(1),
- VERSION_PROBING(2), // not actually used anymore, but we may hit it during
a rolling upgrade from earlier versions
- ASSIGNMENT_ERROR(3),
- SHUTDOWN_REQUESTED(4);
+ NONE(0, "NONE", "NONE"),
+ INCOMPLETE_SOURCE_TOPIC_METADATA(1,
"INCOMPLETE_SOURCE_TOPIC_METADATA","Missing source topics are existed. To check
which topics are missing, please look into the logs of the consumer group
leader. Only the leaders knows and logs the name of the missing topics."),
+ VERSION_PROBING(2, "VERSION_PROBING", "VERSION_PROBING"), // not actually
used anymore, but we may hit it during a rolling upgrade from earlier versions
+ ASSIGNMENT_ERROR(3, "ASSIGNMENT_ERROR", "Hit an unexpected exception
during task assignment phase of rebalance."),
Review Comment:
```suggestion
ASSIGNMENT_ERROR(3, "ASSIGNMENT_ERROR", "Internal task assignment error.
Check the group leader logs for details."),
```
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorError.java:
##########
@@ -19,20 +19,31 @@
public enum AssignorError {
// Note: this error code should be reserved for fatal errors, as the
receiving clients are future-proofed
// to throw an exception upon an unrecognized error code.
- NONE(0),
- INCOMPLETE_SOURCE_TOPIC_METADATA(1),
- VERSION_PROBING(2), // not actually used anymore, but we may hit it during
a rolling upgrade from earlier versions
- ASSIGNMENT_ERROR(3),
- SHUTDOWN_REQUESTED(4);
+ NONE(0, "NONE", "NONE"),
+ INCOMPLETE_SOURCE_TOPIC_METADATA(1,
"INCOMPLETE_SOURCE_TOPIC_METADATA","Missing source topics are existed. To check
which topics are missing, please look into the logs of the consumer group
leader. Only the leaders knows and logs the name of the missing topics."),
Review Comment:
```suggestion
INCOMPLETE_SOURCE_TOPIC_METADATA(1, "INCOMPLETE_SOURCE_TOPIC_METADATA",
"Missing metadata for source topics. Check the group leader logs for details."),
```
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorError.java:
##########
@@ -19,20 +19,31 @@
public enum AssignorError {
// Note: this error code should be reserved for fatal errors, as the
receiving clients are future-proofed
// to throw an exception upon an unrecognized error code.
- NONE(0),
- INCOMPLETE_SOURCE_TOPIC_METADATA(1),
- VERSION_PROBING(2), // not actually used anymore, but we may hit it during
a rolling upgrade from earlier versions
- ASSIGNMENT_ERROR(3),
- SHUTDOWN_REQUESTED(4);
+ NONE(0, "NONE", "NONE"),
+ INCOMPLETE_SOURCE_TOPIC_METADATA(1,
"INCOMPLETE_SOURCE_TOPIC_METADATA","Missing source topics are existed. To check
which topics are missing, please look into the logs of the consumer group
leader. Only the leaders knows and logs the name of the missing topics."),
+ VERSION_PROBING(2, "VERSION_PROBING", "VERSION_PROBING"), // not actually
used anymore, but we may hit it during a rolling upgrade from earlier versions
Review Comment:
```suggestion
VERSION_PROBING(2, "VERSION_PROBING", "Could not read internal rebalance
metadata due to unknown encoding version."), // not actually used anymore, but
we may hit it during a rolling upgrade from earlier versions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
