chia7712 commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1584100563
##########
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##########
@@ -106,6 +106,7 @@ public List<Extension> getAdditionalExtensions() {
},
(AfterTestExecutionCallback) context -> clusterShim.stop(),
new ClusterInstanceParameterResolver(clusterShim),
+ new GenericParameterResolver<>(clusterShim,
ZkClusterInstance.class),
Review Comment:
This change involve the conflicts. For another, it seems to me this could
encourage developers to use specific type of `ClusterInstance`. I agree there
are some test cases requiring the specific cluster type. They can cast the
`ClusterInstance` to either `zk` and `Raft` so it seems to me enabling
injection is overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
