jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1581343739
##########
core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala:
##########
@@ -324,15 +323,11 @@ class DumpLogSegmentsTest {
val lastContainedLogTimestamp = 10000
TestUtils.resource(
- RecordsSnapshotWriter.createWithHeader(
- () => metadataLog.createNewSnapshot(new OffsetAndEpoch(0, 0)),
- 1024,
- MemoryPool.NONE,
- new MockTime,
- lastContainedLogTimestamp,
- CompressionType.NONE,
- MetadataRecordSerde.INSTANCE,
- ).get()
+ new RecordsSnapshotWriter.Builder()
Review Comment:
Yes. It found a small bug in the dump log tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
