TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2072107254
> Thank you for the changes.
>
> Is there a reason to prefer the `java.lang.` prefix?
There is no special reason, Removing prefix is ok.
Following other code, Removing this prefix, thanks for your remind.
>
> There are other uses of `System.getProperty("line.separator")`, should
those be changed too?
>
> * clients/src/main/java/org/apache/kafka/common/utils/Shell.java
> * clients/src/main/java/org/apache/kafka/common/utils/Utils.java
> * tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java
> * core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
> *
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSinkTaskTest.java
These are removed if you use the newest trunk branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
