showuon commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1575561675
##########
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##########
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
AbstractLogCleanerIntegrati
// Set the last modified time to an old value to force deletion of old
segments
val endOffset = log.logEndOffset
log.logSegments.foreach(_.lastModified = time.milliseconds - (2 *
retentionMs))
- TestUtils.waitUntilTrue(() => log.logStartOffset == endOffset,
+ TestUtils.waitUntilTrue(() => 1 == log.numberOfSegments,
"Timed out waiting for deletion of old segments")
- assertEquals(1, log.numberOfSegments)
+ assertEquals(log.logStartOffset, endOffset)
Review Comment:
I'm re-triggering the CI since there are 2 jobs not finished. Meanwhile,
could you help explain why we need these 2 changes in v3.6, but not in
v3.7/trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
