lianetm commented on code in PR #15753:
URL: https://github.com/apache/kafka/pull/15753#discussion_r1572508072
##########
tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py:
##########
@@ -56,12 +56,7 @@ def _verify_roundrobin_assignment(self, consumer):
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
)
- @matrix(
- metadata_quorum=quorum.all_kraft,
- use_new_coordinator=[True],
- group_protocol=consumer_group.all_group_protocols
Review Comment:
Hey, sorry I'm late to this party, but important concern. Don't we want to
keep testing this with the new coordinator and the classic protocol? I would
say yes. I would expect we only want to exclude the consumer protocol, so we
would want to keep the test with the params it had, but changing
`group_protocol=consumer_group.classic`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
