johnnychhsu commented on code in PR #15595:
URL: https://github.com/apache/kafka/pull/15595#discussion_r1565975540
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##########
@@ -436,6 +436,7 @@ private void initializeResources() {
log.info("Initialized topic-based RLMM resources
successfully");
} catch (Exception e) {
log.error("Encountered error while initializing
producer/consumer", e);
+ initializationFailed = true;
Review Comment:
when the topic creation failed, currently it sets `initializationFailed` to
true, and if it failed when init producer, consumer, it's not set now. Do we
need to set `initializationFailed` when the producer/consumer init fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
