mimaison commented on code in PR #15697:
URL: https://github.com/apache/kafka/pull/15697#discussion_r1565973156
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -870,6 +875,7 @@ object KafkaConfig {
.define(CreateTopicPolicyClassNameProp, CLASS, null, LOW,
CreateTopicPolicyClassNameDoc)
.define(AlterConfigPolicyClassNameProp, CLASS, null, LOW,
AlterConfigPolicyClassNameDoc)
.define(LogMessageDownConversionEnableProp, BOOLEAN,
LogConfig.DEFAULT_MESSAGE_DOWNCONVERSION_ENABLE, LOW,
LogMessageDownConversionEnableDoc)
+ .define(LogDirFailureTimeoutMsProp, LONG,
Defaults.LOG_DIR_FAILURE_TIMEOUT_MS, atLeast(0), MEDIUM,
LogDirFailureTimeoutMsDoc)
Review Comment:
In the KIP the accepted value range is defined as >= 1. I wonder if values
below 1s actually make much sense.
Also the importance was defined as low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
