lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045483420
Good catch @dajac , I missed that. Checking the metadata version in the `maybeUpdateSubscriptionMetadata` before we do the actual pattern update would definitely save some unneeded regex checks, just like the legacy does [here](https://github.com/apache/kafka/blob/f895ab5145077c5efa10a4a898628d901b01e2c2/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java#L437), makes total sense to me. What do you think @Phuc-Hong-Tran? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
