showuon commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1555327569
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##########
@@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws Exception {
assertEquals(assignments,
getReplicaAssignmentForPartitions(adminClient, new
HashSet<>(asList(new TopicPartition("foo", 0), new TopicPartition("bar", 0)))));
+
+ assignments.clear();
Review Comment:
Sorry, what's the purpose we explicitly clear `assignments` here? I think
this is only used as local scope variable, we should not clear it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
