chia7712 commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1552954260
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition,
object Partition {
private val metricsGroup = new KafkaMetricsGroup(classOf[Partition])
- def apply(topicPartition: TopicPartition,
+ def apply(topicIdPartition: TopicIdPartition,
time: Time,
replicaManager: ReplicaManager): Partition = {
+ Partition(
Review Comment:
not sure whether we need this new `apply`. No callers have
`TopicIdPartition` and hence they have to create `TopicIdPartition` to use this
`apply`
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition,
delayedOperations: DelayedOperations,
metadataCache: MetadataCache,
logManager: LogManager,
- alterIsrManager: AlterPartitionManager) extends Logging {
+ alterIsrManager: AlterPartitionManager,
+ @volatile private var _topicId: Option[Uuid] = None // TODO:
merge topicPartition and _topicId into TopicIdPartition once TopicId persist in
most of the code
Review Comment:
Can we add jira link to the comment? The reader can trace the updates easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
