lianetm commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1548571273
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcherUtils.java:
##########
@@ -240,20 +241,48 @@ Map<TopicPartition, Long> getOffsetResetTimestamp() {
return offsetResetTimestamps;
}
- static Map<TopicPartition, OffsetAndTimestamp>
buildOffsetsForTimesResult(final Map<TopicPartition, Long> timestampsToSearch,
- final
Map<TopicPartition, ListOffsetData> fetchedOffsets) {
- HashMap<TopicPartition, OffsetAndTimestamp> offsetsByTimes = new
HashMap<>(timestampsToSearch.size());
+ static <T> Map<TopicPartition, T> buildListOffsetsResult(
Review Comment:
This generic `buildListOffsetsResult` is currently only being used from
`buildOffsetsForTimesResult`, was the intention to used it also from
`buildOffsetsForTimeInternalResult`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
