FilipePintoReis commented on PR #15617: URL: https://github.com/apache/kafka/pull/15617#issuecomment-2030926033
Thanks for the prompt reply @soarez ! I'm playing around with these servers and extending their behaviour, I don't think these tests will be useful for open source. That said, I do believe there's a problem worth solving here and instead of presenting the problem itself, I presented a solution. Mea culpa. I will update the description explaining the problem and proposed solution. In the mean time, I can see some room for improvement in my implementation. As you pointed out: ``` What those two are meant to have in common is defined in `KafkaBroker`. ```` The method `createReplicaManager` would be better suited in `KafkaBroker` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
