Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545058512
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
this.timestamp = timestamp;
}
+ @Override
+ public String toString() {
+ return "Row[name:" + name + ",partition:" + partition +
",timestamp:" + timestamp;
Review Comment:
I tried to do the refactoring to use `offset` rather than `timestamp`, but
I'm a bit lost as in how I can get the offset number from the `GetOffsetShell`.
I tried to read through the CI output but couldn't locate where the output is
an offset rather than the timestamp. Could you point me to the outputs that you
saw so that I can get more context of it ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
