mimaison commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1543174303
##########
core/src/main/scala/kafka/controller/PartitionStateMachine.scala:
##########
@@ -486,7 +486,7 @@ class ZkPartitionStateMachine(config: KafkaConfig,
} else {
val (logConfigs, failed) = zkClient.getLogConfigs(
partitionsWithNoLiveInSyncReplicas.iterator.map { case (partition, _)
=> partition.topic }.toSet,
- config.originals()
+ config.extractLogConfigMap
Review Comment:
It looks like this breaks `testOfflinePartitionToOnlinePartitionTransition()`
```
Wanted but not invoked:
controllerBrokerRequestBatch.addLeaderAndIsrRequestForBrokers(
List(5),
t-0,
(Leader:5,ISR:5,LeaderRecoveryState:RECOVERED,LeaderEpoch:1,ZkVersion:2,ControllerEpoch:50),
ReplicaAssignment(replicas=5, addingReplicas=, removingReplicas=),
false
);
-> at
kafka.controller.AbstractControllerBrokerRequestBatch.addLeaderAndIsrRequestForBrokers(ControllerChannelManager.scala:421)
However, there was exactly 1 interaction with this mock:
controllerBrokerRequestBatch.newBatch();
-> at
kafka.controller.ZkPartitionStateMachine.handleStateChanges(PartitionStateMachine.scala:158)
at
kafka.controller.AbstractControllerBrokerRequestBatch.addLeaderAndIsrRequestForBrokers(ControllerChannelManager.scala:421)
at
kafka.controller.PartitionStateMachineTest.testOfflinePartitionToOnlinePartitionTransition(PartitionStateMachineTest.scala:275)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
