chickenchickenlove commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -523,7 +523,17 @@ private RepartitionTopics prepareRepartitionTopics(final
Cluster metadata) {
final boolean isMissingInputTopics =
!repartitionTopics.missingSourceTopicExceptions().isEmpty();
if (isMissingInputTopics) {
if (!taskManager.topologyMetadata().hasNamedTopologies()) {
- throw new MissingSourceTopicException("Missing source
topics.");
Review Comment:
@mjsax thanks for your comments!
> Was Bruno meant was, that we need to add log.error(...) to log the error
message before throwing the exception. Seems you did not add this yet?
No, i created new commits. Please refer to images below 🙇♂️
In this Image, Bruno say `In addition to throwing the exception you would
also log the error.`
<img width="782" alt="image"
src="https://github.com/apache/kafka/assets/90125071/dc652778-ec5d-4d2b-90d4-950839adf2aa";>
and then, I have made these changes to reflect that comment to maintain
readability.
you can see this
[commit](https://github.com/apache/kafka/commit/3f16d28fd07bec76a980b184d7ba708d7d7c9b0c#diff-571894e60232d30f3754d03d122d653e5f2cff4fa646a59ba25688f9aea77318R526-R527).
<img width="802" alt="image"
src="https://github.com/apache/kafka/assets/90125071/f2551117-a9a0-4b75-8886-063aa0dc6b34";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
