gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1540136195
########## streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java: ########## Review Comment: I assumed that this would be necessary. I think either could work, and it's up to the your taste. If this enum is only useful for this one class, that could indicate that the the enum and joiner are too coupled. I'm not familiar with Streams, but maybe there's another class that could benefit from this functionality? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
