mimaison commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1539417806
##########
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##########
@@ -186,6 +264,19 @@ public void testImage2RoundTrip() {
testToImage(IMAGE2);
}
+ public void testApplyDelta2() {
Review Comment:
Is this missing the `@Test` annotation?
##########
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##########
@@ -128,6 +128,39 @@ public void testPreControlledShutdownStateVersion() {
TEST_RECORDS.get(1)));
}
+ /**
+ * Test downgrading to a MetadataVersion that doesn't support ZK migration.
+ */
+ @Test
+ public void testPreZkMigrationSupportVersion() throws Throwable {
Review Comment:
This does not throw so we can remove `throws Throwable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
