chia7712 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1538726557


##########
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##########
@@ -132,9 +133,9 @@ public void testCompressDecompress(CompressionType 
compressionType) throws IOExc
         } else {
             assertArrayEquals(testString, compressed);
         }
-
         ByteBuffer decompressed = ClientTelemetryUtils.decompress(compressed, 
compressionType);
+        byte[] actualResult = Utils.toArray(decompressed, testString.length);

Review Comment:
   `byte[] actualResult = Utils.toArray(decompressed);`
   
   we should not set the size in order to check the `flip` (i.e the return 
buffer is ready to read) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to