ocadaruma commented on code in PR #15574:
URL: https://github.com/apache/kafka/pull/15574#discussion_r1537399407
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -201,7 +201,7 @@ public class ProducerConfig extends AbstractConfig {
/** <code>buffer.memory</code> */
public static final String BUFFER_MEMORY_CONFIG = "buffer.memory";
private static final String BUFFER_MEMORY_DOC = "The total bytes of memory
the producer can use to buffer records waiting to be sent to the server. If
records are "
- + "sent faster than they
can be delivered to the server the producer will block for <code>" +
MAX_BLOCK_MS_CONFIG + "</code> after which it will throw an exception."
+ + "sent faster than they
can be delivered to the server the producer will block for <code>" +
MAX_BLOCK_MS_CONFIG + "</code> after which it will end up with failed future."
Review Comment:
Makes sense. Let me revise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
