[ 
https://issues.apache.org/jira/browse/KAFKA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830251#comment-17830251
 ] 

Dmitry Werner edited comment on KAFKA-16415 at 3/24/24 1:22 PM:
----------------------------------------------------------------

[~chia7712] I have checked that the following utilities correctly handle the 
'-help' and '-version' options using inside 
CommandLineUtils#maybePrintHelpOrVersion:
 * kafka-broker-api-versions.sh (BrokerVersionCommandOptions)
 * kafka-dump-log.sh (DumpLogSegments)
 * kafka-delete-records.sh (DeleteRecordsCommand)
 * kafka-leader-election.sh (LeaderElectionCommand)
 * kafka-log-dirs.sh (LogDirsCommand)

The MirrorMaker tool (connect-mirror-maker.sh) does not inherit 
CommandDefaultOptions and does not declare support for the "version" option. 
The help option is implemented by default for this tool.


was (Author: JIRAUSER300605):
[~chia7712] I have checked that the following utilities correctly handle the 
'--help' and '--version' options using inside 
CommandLineUtils#maybePrintHelpOrVersion:
 * kafka-broker-api-versions.sh (BrokerVersionCommandOptions)
 * kafka-dump-log.sh (DumpLogSegments)
 * kafka-delete-records.sh (DeleteRecordsCommand)
 * kafka-leader-election.sh (LeaderElectionCommand)
 * kafka-log-dirs.sh (LogDirsCommand)

The MirrorMaker tool (connect-mirror-maker.sh) does not inherit 
CommandDefaultOptions and does not declare support for the "version" option. 
The help option is implemented by default for this tool.

> Make sure all subclass of CommandDefaultOptions can process "--help" and 
> "–version"
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-16415
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16415
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Dmitry Werner
>            Priority: Minor
>              Labels: newbie
>
> grep the code base and it seems following tools does not process "--help" and 
> "–version" by `printUsageAndExit`
> BrokerVersionCommandOptions
> DumpLogSegments
> MirrorMaker
> DeleteRecordsCommand
> LeaderElectionCommand
> LogDirsCommand



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to