kirktrue commented on code in PR #15576:
URL: https://github.com/apache/kafka/pull/15576#discussion_r1535030295
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -692,7 +692,12 @@ def test_file_source_and_sink(self, security_protocol,
exactly_once_source, conn
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
)
- def test_bounce(self, clean, connect_protocol, metadata_quorum,
use_new_coordinator=False):
+ @matrix(
+ metadata_quorum=[quorum.isolated_kraft],
+ use_new_coordinator=[True],
+ group_protocol=consumer_group.all_group_protocols
+ )
Review Comment:
We need the `clean` and `connect_protocol` values to be included.
```suggestion
@matrix(
clean=[True, False],
connect_protocol=['sessioned', 'compatible', 'eager'],
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True],
group_protocol=consumer_group.all_group_protocols
)
```
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -929,7 +940,12 @@ def test_exactly_once_source(self, clean,
connect_protocol, metadata_quorum, use
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
Review Comment:
```suggestion
use_new_coordinator=[False]
```
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -929,7 +940,12 @@ def test_exactly_once_source(self, clean,
connect_protocol, metadata_quorum, use
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
)
- def test_transformations(self, connect_protocol, metadata_quorum,
use_new_coordinator=False):
+ @matrix(
+ metadata_quorum=[quorum.isolated_kraft],
+ use_new_coordinator=[True],
+ group_protocol=consumer_group.all_group_protocols
+ )
Review Comment:
We still need the `connect_protocol` here:
```suggestion
@matrix(
connect_protocol=['sessioned', 'compatible', 'eager'],
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True],
group_protocol=consumer_group.all_group_protocols
)
```
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -823,6 +829,11 @@ def test_bounce(self, clean, connect_protocol,
metadata_quorum, use_new_coordina
metadata_quorum=[quorum.isolated_kraft],
use_new_coordinator=[True, False]
)
+ @matrix(
+ metadata_quorum=[quorum.isolated_kraft],
+ use_new_coordinator=[True],
+ group_protocol=consumer_group.all_group_protocols
+ )
Review Comment:
Either we need to add the `group_protocol` parameter, or else just remove
this new `@matrix`.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
