showuon commented on code in PR #15561:
URL: https://github.com/apache/kafka/pull/15561#discussion_r1533536882
##########
examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java:
##########
@@ -215,6 +238,39 @@ private long getRemainingRecords(KafkaConsumer<Integer,
String> consumer) {
}).sum();
}
+ /**
+ * When we get a generic {@code KafkaException} while processing records,
we retry up to {@code MAX_RETRIES} times.
+ * If we exceed this threshold, we log and error and move on to the next
batch of records.
+ * In a real world application you may want to to send these records to a
DLQ for further processing.
Review Comment:
1. we log [an] error
2. Should we spell the DLQ out in case users doesn't know it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
