nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530813020
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##########
@@ -144,18 +145,18 @@ private void
testWithConsumerGroup(java.util.function.Consumer<Runnable> withCon
withConsumerGroup.accept(() -> {
String topic = inputPartition >= 0 ? inputTopic + ":" +
inputPartition : inputTopic;
ConsumerGroupCommand.ConsumerGroupService service =
getConsumerGroupService(getArgs(GROUP, topic));
- scala.Tuple2<Errors, scala.collection.Map<TopicPartition,
Throwable>> res = service.deleteOffsets(GROUP,
seq(Collections.singletonList(topic)).toList());
- Errors topLevelError = res._1;
- scala.collection.Map<TopicPartition, Throwable> partitions =
res._2;
+ Tuple2<Errors, Map<TopicPartition, Throwable>> res =
service.deleteOffsets(GROUP, Collections.singletonList(topic));
Review Comment:
I think usage of Entry is a great idea.
Will implement it after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
