johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527503839
##########
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##########
@@ -40,15 +48,28 @@ public KafkaMetric(Object lock, MetricName metricName,
MetricValueProvider<?> va
this.time = time;
}
+ /**
+ * Get the configuration of this metric
+ * @return Return the config of this metric
+ */
public MetricConfig config() {
return this.config;
Review Comment:
I think you are right, there is a lock for setter, we should have a lock for
getter as well.
Thanks for the suggestion, let me add that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
