jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526861466
##########
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java:
##########
@@ -392,7 +393,8 @@ public enum Errors {
UNKNOWN_CONTROLLER_ID(116, "This controller ID is not known.",
UnknownControllerIdException::new),
UNKNOWN_SUBSCRIPTION_ID(117, "Client sent a push telemetry request with an
invalid or outdated subscription ID.", UnknownSubscriptionIdException::new),
TELEMETRY_TOO_LARGE(118, "Client sent a push telemetry request larger than
the maximum size the broker will accept.", TelemetryTooLargeException::new),
- INVALID_REGISTRATION(119, "The controller has considered the broker
registration to be invalid.", InvalidRegistrationException::new);
+ INVALID_REGISTRATION(119, "The controller has considered the broker
registration to be invalid.", InvalidRegistrationException::new),
+ ABORTABLE_TRANSACTION(120, "This maps to all errors which can be fixed by
aborting the current transaction.", AbortableTransactionException::new);
Review Comment:
Minor nit here with the comment. Maybe we can say -- something like
"The server encountered an error with the transaction. The client can abort
the transaction to continue using this transactional ID."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
