jolshan commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524069898
##########
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##########
@@ -35,24 +35,12 @@ public class BoundedList<E> implements List<E> {
private final int maxLength;
private final List<E> underlying;
- public static <E> BoundedList<E> newArrayBacked(int maxLength) {
- return new BoundedList<>(maxLength, new ArrayList<>());
- }
-
- public static <E> BoundedList<E> newArrayBacked(int maxLength, int
initialCapacity) {
Review Comment:
My understanding here is that we do want to know an expected size to start
out with, but we shouldn't necessarily link it directly to an array we are
passing in as the constructor does. Does that mean the deleted code here is
actually the behavior we want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
