chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1521123429
##########
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##########
@@ -243,33 +243,20 @@ public MemoryRecords build() {
/**
* Get the max timestamp and its offset. The details of the offset
returned are a bit subtle.
*
- * If the log append time is used, the offset will be the last offset
unless no compression is used and
Review Comment:
@showuon @junrao thanks for this change and I learn a lot from it.
BTW, should we document this behavior? I mean how we decide the offset of
max timestamp when there are multi-records having same timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
