mjsax commented on code in PR #15500:
URL: https://github.com/apache/kafka/pull/15500#discussion_r1518395847
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -285,8 +285,10 @@ public class ProducerConfig extends AbstractConfig {
"<ul>" +
"<li>If not set, the default partitioning logic is used. " +
"This strategy send records to a partition until at least " +
BATCH_SIZE_CONFIG + " bytes is produced to the partition. It works with the
strategy:" +
- "<p> 1) If no partition is specified but a key is present, choose
a partition based on a hash of the key." +
- "<p> 2) If no partition or key is present, choose the sticky
partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are
produced to the partition." +
+ "<ol>" +
+ "<li>If no partition is specified but a key is present, choose a
partition based on a hash of the key." +
Review Comment:
```suggestion
"<li>If no partition is specified but a key is present, choose a
partition based on a hash of the key.</li>" +
```
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -285,8 +285,10 @@ public class ProducerConfig extends AbstractConfig {
"<ul>" +
"<li>If not set, the default partitioning logic is used. " +
"This strategy send records to a partition until at least " +
BATCH_SIZE_CONFIG + " bytes is produced to the partition. It works with the
strategy:" +
- "<p> 1) If no partition is specified but a key is present, choose
a partition based on a hash of the key." +
- "<p> 2) If no partition or key is present, choose the sticky
partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are
produced to the partition." +
+ "<ol>" +
+ "<li>If no partition is specified but a key is present, choose a
partition based on a hash of the key." +
+ "<li>If no partition or key is present, choose the sticky
partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are
produced to the partition." +
Review Comment:
```suggestion
"<li>If no partition or key is present, choose the sticky
partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are
produced to the partition.</li>" +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
