gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1516017140
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
parentFile.mkdirs()
- JTestUtils.tempDirectory(parentFile.toPath, null)
+ val result = JTestUtils.tempDirectory(parentFile.toPath, null)
Review Comment:
> if we decide to cleanup parent folder also, we should do same thing for
java code.
I've made the following changes in
[3af0426](https://github.com/apache/kafka/pull/15289/commits/3af0426481cedd79f6f827317c9f144ea68fb8cb):
* Scala TestUtils now delegates to the function in JTestUtils
* The function is modified such that we delete the `rootDir` on JVM exit if
it didn't exist prior to the function being invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
